This repository has been archived by the owner on Jun 14, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses truffle 745, where a third-party assertions library modeled on
Assert.sol
has been written and is being used exclusive ofAssert.sol
. There's no convenient way to link it to the test contracts and expose its TestEvent on their ABI. As a result, only the transaction receipt's raw logs are available and test failures aren't being processed correctly.This PR adds a manual decoding step to the test evaluation step when a) the
result.logs
are empty and b)result.receipt.logs
are not empty. It assumes the third party library will use a TestEvent function signature identical to the one inAssert.sol
.Needs tests but those will be over in the
truffle
repo.