Merge pull request #4749 from trufflesuite/fix/box-rejects

Await `assert.rejects` in box tests

packages/box/test/sandbox.js

@@ -11,9 +11,9 @@ describe("Box.sandbox", () => {
     assert(config.truffle_directory);
   });
 
-  it("errors when passed an invalid options configuration", () => {
+  it("errors when passed an invalid options configuration", async () => {
     options = { name: "badBox", force: true, setGracefulCleanup: true };
-    assert.rejects(async () => {
+    await assert.rejects(async () => {
       await sandbox(options);
     }, "should have rejected!");
   });

packages/box/test/utils-unbox.js

@@ -23,18 +23,18 @@ describe("utils", () => {
   });
 
   describe("fetchRepository", () => {
-    it("rejects when passed non-strings and non-objects", () => {
-      assert.rejects(async () => {
+    it("rejects when passed non-strings and non-objects", async () => {
+      await assert.rejects(async () => {
         await utils.fetchRepository(false);
       }, "should have rejected!");
 
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await utils.fetchRepository(123214);
       }, "should have rejected!");
     });
   });
 
-  describe("verifySourcePath", async() => {
+  describe("verifySourcePath", async () => {
     const errorStatus = 401;
     const errorMessage = "Network error: oh noes!";
     const authError = {
@@ -43,10 +43,11 @@ describe("utils", () => {
       },
       message: errorMessage
     };
+    let url;
 
-    before(async() => {
+    before(async () => {
       url = "https://github.com/truffle-box/bare-box";
-      sinon.stub(axios, 'head').throws(authError);
+      sinon.stub(axios, "head").throws(authError);
     });
 
     it("Includes network error message on non 404 failure", async () => {
@@ -55,11 +56,12 @@ describe("utils", () => {
         assert(false, "verifyVCSURL should have thrown!");
       } catch (error) {
         const { response, message } = error;
-        assert.equal(response.status, errorStatus); 
-        assert(message.endsWith(errorMessage), "Axios error message should be the suffix");
+        assert.equal(response.status, errorStatus);
+        assert(
+          message.endsWith(errorMessage),
+          "Axios error message should be the suffix"
+        );
       }
-    })
-
+    });
   });
-
 });