Add error reporting to catch typos

trufflesuite · Jun 5, 2020 · ea607e1 · ea607e1
1 parent f40af9f
commit ea607e1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/packages/core/lib/debug/cli.js b/packages/core/lib/debug/cli.js
@@ -48,7 +48,7 @@ class CLIDebugger {
       let warningStrings = [];
       if (badFetchers.length > 0) {
         warningStrings.push(
-          `Errors occurred connecting to ${badFetchers.join(", ")}$.`
+          `Errors occurred connecting to ${badFetchers.join(", ")}.`
         );
       }
       if (badAddresses.length > 0) {

diff --git a/packages/core/lib/debug/external.js b/packages/core/lib/debug/external.js
@@ -37,11 +37,16 @@ class DebugExternalHandler {
     );
     const userFetcherNames = this.config.sourceFetchers;
     //sort/filter fetchers by user's order, if given; otherwise use default order
-    let sortedFetchers;
+    let sortedFetchers = [];
     if (userFetcherNames) {
-      sortedFetchers = userFetcherNames
-        .map(name => allFetchers.find(Fetcher => Fetcher.fetcherName === name))
-        .filter(Fetcher => Fetcher !== undefined); //kind of a stupid way of writing this, but we're talking about *tiny* lists here
+      for (let name of userFetcherNames) {
+        let Fetcher = allFetchers.find(Fetcher => Fetcher.fetcherName === name);
+        if (Fetcher) {
+          sortedFetchers.push(Fetcher);
+        } else {
+          throw new Error(`Unknown external source service ${name}.`);
+        }
+      }
     } else {
       sortedFetchers = allFetchers;
     }