Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

[Truffle 5.0] No logs for simple transaction #1347

Open
maxaleks opened this issue Oct 16, 2018 · 15 comments
Open

[Truffle 5.0] No logs for simple transaction #1347

maxaleks opened this issue Oct 16, 2018 · 15 comments

Comments

@maxaleks
Copy link

  • ✅ I've asked for help in the Truffle Gitter before filing this issue.

Issue

There are no logs in Truffle 5 for simple (not deployment) transactions when using deploy, as it was in Truffle 4

Steps to Reproduce

module.exports = async (deployer) => {
  const test = await deployer.deploy(Test, { ... });
  await test.transferOwnership('some address', { ... });
};

Expected Behavior

Deploying 'Test' with the details, then hash (and details maybe) of transaction where I call transferOwnership method

Actual Results

I see only details of Test contract deployment

Environment

  • Operating System: macOS Mojave
  • Ethereum client: geth
  • Truffle version (truffle version): 5.0.0-beta.0
  • node version (node --version): 9.4.0
  • npm version (npm --version): 5.6.0
@gnidan
Copy link
Contributor

gnidan commented Oct 18, 2018

Thanks for opening an issue for this. We're aware of this problem, will need to prioritize implementation. (Or feel free to open a PR!)

@roderik
Copy link
Contributor

roderik commented Oct 21, 2018

See #1252

@stale
Copy link

stale bot commented Dec 20, 2018

Thank you for raising this issue! It has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you would like to keep this issue open, please respond with information about the current state of this problem.

@stale stale bot added the stale label Dec 20, 2018
@stale
Copy link

stale bot commented Dec 27, 2018

There has been no new activity on this issue since it was marked as stale 7 days ago, so it is being automatically closed. If you'd like help with this or a different problem, please open a new issue. Thanks!

@stale stale bot closed this as completed Dec 27, 2018
@gnidan gnidan reopened this Dec 27, 2018
@stale
Copy link

stale bot commented Dec 27, 2018

Thanks for your response! This issue is no longer considered stale and someone from the Truffle team will try to respond as soon as they can.

@stale stale bot removed the stale label Dec 27, 2018
@stale
Copy link

stale bot commented Apr 26, 2019

Thank you for raising this issue! It has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you would like to keep this issue open, please respond with information about the current state of this problem.

@stale stale bot added the stale label Apr 26, 2019
@stale
Copy link

stale bot commented May 10, 2019

There has been no new activity on this issue since it was marked as stale 7 days ago, so it is being automatically closed. If you'd like help with this or a different problem, please open a new issue. Thanks!

@stale stale bot closed this as completed May 10, 2019
@roderik
Copy link
Contributor

roderik commented May 11, 2019

Do not feel this should be closed.

@gnidan
Copy link
Contributor

gnidan commented May 12, 2019

Nope definitely should stay open

@gnidan gnidan reopened this May 12, 2019
@stale
Copy link

stale bot commented May 12, 2019

Thanks for your response! This issue is no longer considered stale and someone from the Truffle team will try to respond as soon as they can.

1 similar comment
@stale
Copy link

stale bot commented May 12, 2019

Thanks for your response! This issue is no longer considered stale and someone from the Truffle team will try to respond as soon as they can.

@pklinger
Copy link

pklinger commented Oct 3, 2019

this bug is open >1 year. is a fix in sight?

@gnidan
Copy link
Contributor

gnidan commented Oct 3, 2019

@pklinger We're in the process of getting the new Event system accepted for merge. We're treating having a path to address this issue as acceptance criteria for that system. Event system is planned for v5.1, which you can see on the ZenHub release.

@pklinger
Copy link

pklinger commented Oct 4, 2019

Thanks for pointing there. You should add this issue's id to the "This Issue is blocking" list at https://app.zenhub.com/workspaces/truffle-dev-5c67177dfd28fb7faae0855e/issues/trufflesuite/truffle/2199, to not forget about issue #1347 in the "icebox". At least i'm unable to find it on zenhub where i'd expect it when following your guidline on finding v5.1 releases.

@gnidan
Copy link
Contributor

gnidan commented Oct 4, 2019

#2199 is set as blocking this issue. I moved this (#1347) to the Blocked column.

This isn't part of the schedule for v5.1... the plan was to release the event system, then resolve this missing logs problem, although I'm happy to revisit that decision. My thinking is that this issue is a bug, not a feature, and so the fix here could be a patch release.

But, It'd be nice to get this into v5.1, certainly. I just don't think anyone on the team has capacity to take on the work, and I'm hesitant to delay v5.1 past October.

I'll mark this "help wanted" in case anyone else is interested. The work here should target the reporter branch, at least until #2035 is merged. Docs for the event system can be found on the corresponding PR (see here specifically), but there might be code changes required.

In the meantime, I'll have more attention to devote to this myself after DevCon, and that might change my assumptions.

(EDIT: oh, I guess this isn't "blocked", per se... it's just that the Event system isn't merged yet, and is thus subject to change. But if it has to change to support simple transaction logs in migrations, then we should know about that!)

(EDIT two: meant to cc @eggplantzzz)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants