Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

hdwallet-provider uses old ethereumjs-util #5260

Closed
wbt opened this issue Jul 5, 2022 · 6 comments · Fixed by #5261
Closed

hdwallet-provider uses old ethereumjs-util #5260

wbt opened this issue Jul 5, 2022 · 6 comments · Fixed by #5261

Comments

@wbt
Copy link
Contributor

wbt commented Jul 5, 2022 •
edited
Loading

Issue

@truffle/hdwallet-provider specifies ethereumjs-util@6. This uses an older version of @types/bn.js which aren't compatible with the new types incorporated by #5177, a breaking change rolled out in Truffle's latest patch-level release.
wbt added a commit to wbt/truffle that referenced this issue Jul 5, 2022
@wbt
Use newer ethereumjs-util
26501a5 
Hopefully fixes trufflesuite#5260
@wbt wbt mentioned this issue Jul 5, 2022
Merged
@eggplantzzz
Copy link
Contributor

Thanks for reporting @wbt!

@haltman-at
Copy link
Contributor

(Temporarily reopening this per our usual practice of close-on-release rather than close-on-merge.)

@eggplantzzz
Copy link
Contributor

Did we not release this change?

@cds-amal
Copy link
Member

Did we not release this change?

Nope. The last release was Jul-08 and the associated PR (#5261) was merged on Jul-11, three days later.

@cds-amal cds-amal reopened this Jul 11, 2022
@eggplantzzz
Copy link
Contributor

Ah ok sorry, I thought this was released.

@cliffoo
Copy link
Contributor

cliffoo commented Jul 15, 2022

Fixed in pull#5261 and in the latest release v5.5.22. Thanks @wbt and @eggplantzzz!

@cliffoo cliffoo closed this as completed Jul 15, 2022
This was referenced Aug 5, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use newer ethereumjs-util wbt/truffle
5 participants
@wbt @cds-amal @eggplantzzz @haltman-at @cliffoo