This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Internal improvement: Swap out TravisCI for CircleCI for Colony job #3071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haltman-at
approved these changes
May 22, 2020
There was a problem hiding this comment.
Well, if the tests pass, it seems good to me!
...of course, the tests on this branch don't include the Colony tests, since we only run those on develop. But I'm going to assume you tested actually running them? Still, that the tests aren't accidentally running on this branch is at least a good sign. :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis has a job timeout of 50 minutes. Lately the
COLONYjob has been timin' out, likely due toganache-clibeing slower post gas estimation refactoring/bug fixes.CircleCI supports longer running jobs, so let's use it for this one instead!