This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Ensure artifacts are saved with db info #3524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d86ed4b
to
892d295
Compare
e4f8208
to
c042459
Compare
892d295
to
627e121
Compare
fainashalts
suggested changes
Nov 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This totally makes sense! LGTM but failing CI.
Yep, sorry, I got jumpy with requesting review, thinking this and #3523 were going to pass 🤭 |
c042459
to
31275ed
Compare
627e121
to
88fb88f
Compare
fainashalts
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
gnidan
added a commit
that referenced
this pull request
Dec 8, 2020
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Dec 8, 2020
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Dec 8, 2020
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Dec 8, 2020
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Dec 9, 2020
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Dec 15, 2020
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Dec 17, 2020
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Dec 18, 2020
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Dec 23, 2020
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Dec 23, 2020
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Jan 5, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Jan 7, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Jan 10, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Jan 10, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Jan 11, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Jan 11, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Jan 11, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Jan 12, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Jan 24, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Jan 26, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Jan 27, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Jan 27, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Jan 30, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Feb 1, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Feb 4, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Feb 5, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Feb 9, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Feb 21, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Feb 22, 2021
…-compile Ensure artifacts are saved with db info
gnidan
added a commit
that referenced
this pull request
Feb 24, 2021
…-compile Ensure artifacts are saved with db info
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that @truffle/db resources are referenced in the resulting
truffle compile
artifacts