Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Integrate preserve functionality into @truffle/core #3818

Merged
merged 16 commits into from
Mar 31, 2021

Conversation

rkalis
Copy link
Contributor

@rkalis rkalis commented Feb 19, 2021

  • Add preserve plugins to @truffle/plugins
  • Change from @gnidan's code: plugin json contains tag rather than defaultTag
  • Integrate preserve functionality into @truffle/core
  • Allow command help to be a thunk instead of an object
  • Add tests in plugins, core, and truffle packages

@rkalis rkalis added filecoin ⏸️ merge after target this PR targets another PR; that other PR should be merged first labels Feb 19, 2021
@rkalis rkalis requested a review from gnidan February 19, 2021 12:48
@rkalis rkalis force-pushed the truffle-preserve-to-ipfs branch from 947ffcc to 0a7be17 Compare February 26, 2021 10:10
@rkalis rkalis force-pushed the truffle-preserve-command branch from ed40f16 to b73efa9 Compare February 26, 2021 10:27
@rkalis rkalis force-pushed the truffle-preserve-command branch 4 times, most recently from fce8206 to b48bcb4 Compare March 10, 2021 16:58
@rkalis rkalis force-pushed the truffle-preserve-to-ipfs branch 2 times, most recently from e5375c3 to fb35f2a Compare March 12, 2021 14:32
@rkalis rkalis force-pushed the truffle-preserve-command branch 2 times, most recently from 1ae34ca to 429f2bf Compare March 12, 2021 18:51
Base automatically changed from truffle-preserve-to-ipfs to develop March 16, 2021 08:12
@rkalis rkalis force-pushed the truffle-preserve-command branch from 725d140 to 19c1826 Compare March 18, 2021 08:58
@rkalis rkalis changed the base branch from develop to truffle-preserve-to-filecoin March 18, 2021 08:59
@rkalis rkalis force-pushed the truffle-preserve-to-filecoin branch from cfec4c1 to e4a5095 Compare March 18, 2021 09:03
@rkalis rkalis force-pushed the truffle-preserve-command branch 2 times, most recently from ec1b758 to 0bb9414 Compare March 18, 2021 16:22
@rkalis rkalis changed the base branch from truffle-preserve-to-filecoin to truffle-preserve-to-buckets March 18, 2021 16:22
@rkalis rkalis force-pushed the truffle-preserve-command branch from 0bb9414 to 13ab28b Compare March 24, 2021 09:01
@rkalis rkalis force-pushed the truffle-preserve-to-buckets branch from 5dfaa25 to 46a9e7f Compare March 29, 2021 18:36
Base automatically changed from truffle-preserve-to-buckets to develop March 29, 2021 21:18
@rkalis rkalis removed the ⏸️ merge after target this PR targets another PR; that other PR should be merged first label Mar 30, 2021
rkalis added 6 commits March 30, 2021 11:15
- Add listAll{CommanPlugins|Recipes|Loaders} to Plugins
- Add code to add `tag` to the plugin definition
- Add Truffle preserve properties to PluginDefinition
- Add tests for new functionality
- Change from @gnidan's code: plugin json contains `tag`
  rather than `defaultTag`
- Update preserve-fs and preserve-to-ipfs to use `tag`
- Add dependencies on the preserve packages (-filecoin)
- Add functionality for help function (rather than object)
- Add preserve to the list of commands
- Add tests to main truffle package
rkalis added 6 commits March 30, 2021 11:16
- Allow untagged recipes (indicating they are downstream recipes)
- Remove all loader-related code and tests
- Update preserve command to match new @truffle/preserve interface
- Provide "path" and "config" inputs by default
- Update tests to check for dependency paths
- Bug fix in @truffle/preserve-fs
- Rename StepsController::log to update & overload the update event
@rkalis rkalis force-pushed the truffle-preserve-command branch from 13ab28b to 4723303 Compare March 30, 2021 09:22
Copy link
Contributor

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good!

@rkalis rkalis merged commit 26d962d into develop Mar 31, 2021
@rkalis rkalis deleted the truffle-preserve-command branch March 31, 2021 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants