This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Repair geth CI jobs #3945
Merged
Repair geth CI jobs #3945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnidan
approved these changes
Mar 24, 2021
| @@ -4,7 +4,7 @@ pragma solidity ^0.5.0; | |||
| contract Loops { | |||
| uint public id; | |||
| constructor() public { | |||
| for(uint i = 0; i < 10000; i++){ | |||
| for(uint i = 0; i < 10000000; i++){ | |||
There was a problem hiding this comment.
Previously --targetgaslimit was set to 7000000. I think the default for Geth is 8000000. So it wasn't running out of gas when I removed the option. Note that the purpose of this contract is to run out of gas and is used by a test to ensure things run out of gas correctly.
This was referenced May 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.