This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Bug fix: Use backslashes on Windows while resolving imports #4195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haltman-at
changed the title
|
Gosh, we really need a windows test runner. I can't think of a way to test this without actually testing on windows :/ |
cds-amal
approved these changes
Jul 21, 2021
|
OK, you've tested it on Windows? |
|
@cds-amal confims that he has so I'm gonna merge this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to address #4193. This needs to be tested on Windows! This is a quick PR that I think should resolve the problem, but I am working without actual testing here.
As best I can tell -- remember, I'm working without testing here -- the problem is that resolution of relative paths is causing aliasing of sources. Because some paths are being given with slashes, but import resolution leads to the use of backslashes instead.
Except, hm, we might need to apply this imports too, not just at the beginning? Uh, I guess I need to go make more changes to this...OK, made that change.