This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Bug fix: Sanitize network name for graphql query in db #4198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnidan
approved these changes
Jul 22, 2021
|
Thanks for the help on this @gnidan! |
This was referenced Oct 17, 2022
This was referenced Nov 30, 2023
This was referenced Jan 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #3981
This PR fixes a bug caused by network names with characters that, when inserted into a GraphQL query, would break the query. For example, the network name "my-network" would break the query due to the "-". The PR sanitizes the name with a regex.