Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Add custom inspect alias to codec inspectors, to support browser-util-inspect #4953

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

gnidan
Copy link
Contributor

@gnidan gnidan commented Mar 28, 2022

browser-util-inspect is pretty cool because it provides the Node.js util.inspect functionality in the browser! It even supports custom inspect functions...

... except instead of looking for the symbol util.inspect.custom, it looks for a method called inspect.

This PR aliases the existing symbol-defined method with an additional inspect interface for use by this package in the browser.

@gnidan gnidan requested a review from haltman-at March 28, 2022 17:55
Copy link
Contributor

@haltman-at haltman-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@gnidan gnidan merged commit 4161f74 into develop Mar 29, 2022
@gnidan gnidan deleted the codec/browser-util-inspect branch March 29, 2022 01:02
@gnidan
Copy link
Contributor Author

gnidan commented Mar 29, 2022

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants