-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Bug fix: Remove incorrect typings from contract #5142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We said we're doing this, right? So let's do it! (Although, should this be marked as a breaking change to contract
?)
@haltman-at oh man, I don't know. I guess they never worked so maybe not? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outta here!
Yep...this was a breaking change on @truffle/contract put out on a patch-level bump. I'd really hoped this cluster of projects would get away from that practice, but it's unfortunately still fairly common. Prior to merging this, there was a way to get Typescript to compile a TypeScript file with the line "import TruffleContract from '@truffle/contract';" (though it would drop that import in the transpiled code) and now previously working code can't even get past that line in failing to compile:
|
In response to #4825, this PR removes the types from @truffle/contract.