This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Upgrade jest to v29 #5507
Merged
Upgrade jest to v29 #5507
+425
−317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliffoo
requested review from
eggplantzzz,
benjamincburns,
haltman-at,
cds-amal,
fainashalts and
lsqproduction
|
Oops nvm jest 29 doesn't support node 12 anymore. Closing. |
|
@cliffoo I think we should tag this as blocked, so it's not forgotten when Truffle eventually drops node 12 support. |
|
True true |
|
Hm rather than leaving this open on the PR board where it takes up space while blocked, it would be better to just have this as an issue for now? (Since what to do is easy, it just needs to be recorded that we have to do it.) |
|
That makes sense. Actually I'll just add a note to the node 18 issue rather than opening a new one. Thanks @haltman-at |
cds-amal
reviewed
Oct 5, 2022
There was a problem hiding this comment.
Jest is up to 29.1.2, and the changelog looks yummy. Is there a reason not to bump up?
|
Nope! This PR just aged. Pushed changes to use latest. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.