Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Prevent spawned Hardhat console from triggering a compile #5872

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

kevinbluer
Copy link
Member

@kevinbluer kevinbluer commented Feb 6, 2023

PR description

This PR prevents the spawned Hardhat console in from-hardhat from triggering a compile (via --no-compile). This is being added to mitigate a circular reference in an upcoming Hardhat plugin that provides support for Truffle Dashboard decoding/debugging.

Testing instructions

One testing approach...

  • Create a local Hardhat project (via git clone https://github.com/amanusk/hardhat-template or equivalent)
  • yarn link to the from-hardhat package from the above
  • Run the following from the node REPL:
    • const FromHardhat = require("@truffle/from-hardhat");
    • await FromHardhat.prepareCompilations()

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if documentation updates are required.

Breaking changes and new features

  • I have added any needed breaking-change and new-feature labels for the appropriate packages.

@kevinbluer kevinbluer marked this pull request as ready for review February 7, 2023 16:39
@cds-amal cds-amal self-requested a review February 7, 2023 17:04
Copy link
Member

@cds-amal cds-amal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @kevinbluer, though it would be prudent to comment why --no-compile is necessary for future maintainers.

Edit: tested with new hardhat project

packages/from-hardhat/src/ask-hardhat.ts Show resolved Hide resolved
@kevinbluer
Copy link
Member Author

Comment added @cds-amal 👍 All good from your side @gnidan as I noticed the addition of the breaking-change: @truffle/from-hardhat label?

@cds-amal
Copy link
Member

cds-amal commented Feb 7, 2023

Hey @kevinbluer, the breaking change label is to communicate a breaking SemVer change (minor update) for the release process.

@kevinbluer
Copy link
Member Author

Ah awesome 👍

Copy link
Contributor

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep all good now from my side! The label is just for housekeeping (for reasons stated)

@kevinbluer kevinbluer merged commit 275339a into develop Feb 7, 2023
@kevinbluer kevinbluer deleted the fix/hardhat-console-no-compile branch February 7, 2023 22:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants