This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Fix console.log when presenting BigInts #5933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because JSON.stringify cannot serialize BigInt, which is a possible type from ganache and solidity logs. Co-authored-by: MicaiahReid <[email protected]>
davidmurdoch
approved these changes
Feb 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because JSON.stringify cannot serialize BigInt, which is a possible type from ganache and solidity logs. Special thanks to @MicaiahReid for the Rubber duck support! 🙇
PR description
This PR fixes an error @emilyJLin95 discovered. If you have a contract that logs a UINT* as the only argument (
console.log(100)), thentruffle developwould crash when the log is presented.Testing instructions
Write a contract that with
console.log(some-int)and invoke the method to present the log. Truffle develop should not crash, and present the log. One way to do this is to introduce aconsole.login MetaCoin's constructor and runtruffle testfrom the console.Documentation
Breaking changes and new features