-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Dashboard notify user if no Frame account is / can be connected #6071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice, so that's what was wrong!
Does everything else work when the account is connected properly?
From a few test transactions it looks like it. Though I did just discover an unhandled case: If you deny connection in Frame, Dashboard does nothing again because Frame remembers that you denied connection to this host. The fix would be the same. @gnidan Should we generalize this instead of having checking for more regex? The notification can just be titled "Wallet connection error" and we can put In this case |
I'm not sure we should generalize this... it might be alright to generalize as "something is wrong with Frame, go check", but I think it's just nicer to specify what is wrong when we know. |
Thanks to curiousapple.eth and @pcaversaccio for bring up the underlying issue!
When using Frame with Dashboard, Dashboard doesn't know what to do if no Frame account is connected. This PR sidesteps wagmi and finds out if that's the case, provides a helpful notification asking the user to connect a Frame account, and hides the notification when Dashboard is ready.
Environment: Frame v0.6.6 (amd64, deb), Frame Companion v0.10.2 (Chrome).
Tested with Frame Companion's two options: Injecting as Frame / MetaMask.