-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds terraform-docs as a linter 📄 #946
base: main
Are you sure you want to change the base?
Conversation
⏱️ 27m total CI duration on this PR
|
output: rewrite | ||
formatter: true | ||
run_from: ${target_directory} | ||
run: terraform-docs markdown --output-file=README.md . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One note here: This is my team and I's (and I would suspect many many others) most common usage when using terraform-docs
with terraform child + root modules. However, the tool is fairly configurable and can be run in a lot of different ways. I didn't see an obvious example of how make these run
commands configurable, so I figured I'd put up this lightly working version for review + ask for feedback from the trunk team.
Do ya'll have any other configurable plugins that I should check out for inspiration to make sure this doesn't need an immediate update from the 2nd person to use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EliSchleifer any thoughts here or ship it and we can deal with any requests for configurability in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix up the name of the command. Otherwise looks good to go
linters/terraform-docs/plugin.yaml
Outdated
main_tool: terraform-docs | ||
description: Generate terraform + tofu module documentation | ||
commands: | ||
- name: terraform-docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command name should more map what the command does than the name of the tool. So in this case given the formatter nature I would set name to "format"
Info
terraform-docs
as a linter plugin to support automatically generating + updating terraform module documentation for terraform projects.