Feat/add snyk #959
Merged
Feat/add snyk #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 54m total CI duration on this PR
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // You know password for the user. | ||
| {name: 'user', password: 'pwd'}, | ||
| // You don't know password for the admin. | ||
| {name: 'admin', password: Math.random().toString(32), canDelete: true}, |
Check failure
Code scanning / CodeQL
Insecure randomness
|
Hi @fsargent! Thanks for the PR! Sorry for the delay in reviewing, I will take a look later today |
|
Thanks for the PR! I've added some setup and test data to your PR to match some of our best practices. Please let me know if the result looks good to you, and I can merge this! |
|
Thank you! You did more of the hard work than I did! It looks great. |
TylerJang27
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add snyk cli for security scans.
As of 2025-01-20 I can't get this to test properly locally because it says snyk isn't enabled. Not sure what might be misconfigured that's causing that. Would love help.