Skip to content

Commit

Permalink
fix: Remove image role attribute from Banner Icon component (#2663)
Browse files Browse the repository at this point in the history
Co-authored-by: James Hancock <[email protected]>
  • Loading branch information
jhancock532 and James Hancock authored Jan 4, 2024
1 parent 6bdf5fb commit 8ddf443
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
2 changes: 0 additions & 2 deletions src/components/banner/BannerIcon/BannerIcon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,9 @@ export const BannerIcon = ({
const classes = classNames('usa-banner__icon usa-media-block__img', className)

return (
// eslint-disable-next-line jsx-a11y/no-redundant-roles
<img
className={classes}
src={src}
role="img"
alt={alt}
aria-hidden="true"
{...imgProps}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ exports[`GovBanner component static content renders consistently in English for
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand All @@ -100,7 +99,6 @@ exports[`GovBanner component static content renders consistently in English for
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand Down Expand Up @@ -215,7 +213,6 @@ exports[`GovBanner component static content renders consistently in English for
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand All @@ -241,7 +238,6 @@ exports[`GovBanner component static content renders consistently in English for
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand Down Expand Up @@ -356,7 +352,6 @@ exports[`GovBanner component static content renders consistently in Spanish for
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand All @@ -382,7 +377,6 @@ exports[`GovBanner component static content renders consistently in Spanish for
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand Down Expand Up @@ -496,7 +490,6 @@ exports[`GovBanner component static content renders consistently in Spanish for
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand All @@ -522,7 +515,6 @@ exports[`GovBanner component static content renders consistently in Spanish for
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand Down Expand Up @@ -636,7 +628,6 @@ exports[`GovBanner component static content renders consistently with default pr
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand All @@ -662,7 +653,6 @@ exports[`GovBanner component static content renders consistently with default pr
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand Down

0 comments on commit 8ddf443

Please sign in to comment.