feat: Add validationStatus prop to Dropdown #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also configure storybook for controls
brandonlenz
requested review from
gidjin,
haworku,
ahobson and
SirenaBorracha
as code owners
…us' into 2364-bl-dropdown-validation-status
brandonlenz
changed the title
|
Edit: Fixed |
gidjin
previously approved these changes
May 31, 2023
gidjin
approved these changes
Jun 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues or PRs
Resolves #2364
How To Test
Unit tests test that this works.
Storybook control for validation status can also be used
Screenshots (optional)