Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove image role attribute from Banner Icon component #2663

Merged
merged 5 commits into from
Jan 4, 2024
Merged

fix: Remove image role attribute from Banner Icon component #2663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8efb5f7
fix: Remove image role attribute from Banner Icon component
Nov 16, 2023
876c5c3
Merge branch 'main' into jh-banner-icon-role-attribute-removal-2662
haworku Dec 27, 2023
476b24a
update GovBanner component snapshots
Jan 3, 2024
1916dfb
Merge branch 'main' into jh-banner-icon-role-attribute-removal-2662
Jan 3, 2024
4633b2b
Merge branch 'jh-banner-icon-role-attribute-removal-2662' of https://…
Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/components/banner/BannerIcon/BannerIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,9 @@ export const BannerIcon = ({
const classes = classNames('usa-banner__icon usa-media-block__img', className)

return (
// eslint-disable-next-line jsx-a11y/no-redundant-roles
<img
className={classes}
src={src}
role="img"
alt={alt}
aria-hidden="true"
{...imgProps}
Expand Down
10 changes: 0 additions & 10 deletions src/components/banner/GovBanner/__snapshots__/GovBanner.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ exports[`GovBanner component static content renders consistently in English for
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand All @@ -100,7 +99,6 @@ exports[`GovBanner component static content renders consistently in English for
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand Down Expand Up @@ -215,7 +213,6 @@ exports[`GovBanner component static content renders consistently in English for
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand All @@ -241,7 +238,6 @@ exports[`GovBanner component static content renders consistently in English for
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand Down Expand Up @@ -356,7 +352,6 @@ exports[`GovBanner component static content renders consistently in Spanish for
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand All @@ -382,7 +377,6 @@ exports[`GovBanner component static content renders consistently in Spanish for
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand Down Expand Up @@ -496,7 +490,6 @@ exports[`GovBanner component static content renders consistently in Spanish for
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand All @@ -522,7 +515,6 @@ exports[`GovBanner component static content renders consistently in Spanish for
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand Down Expand Up @@ -636,7 +628,6 @@ exports[`GovBanner component static content renders consistently with default pr
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand All @@ -662,7 +653,6 @@ exports[`GovBanner component static content renders consistently with default pr
alt=""
aria-hidden="true"
className="usa-banner__icon usa-media-block__img"
role="img"
src="test-file-stub"
/>
<div
Expand Down
Loading