Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add docker auth to circleci config #695

Merged
merged 2 commits into from
Dec 11, 2020
Merged

ci: Add docker auth to circleci config #695

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1c3475
Add docker auth
haworku Dec 7, 2020
6af8cff
eady update version of circle config and leverage workflows/context
eeeady Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
version: 2
version: 2.1
jobs:
build:
docker:
- image: circleci/node:12.16.2
- auth:
password: $DOCKER_PASSWORD
username: $DOCKER_USERNAME
image: circleci/node:12.16.2
working_directory: ~/react-uswds
steps:
- checkout
Expand All @@ -29,3 +32,11 @@ jobs:

- run: yarn lint
- run: yarn danger ci --failOnErrors

workflows:
build:
jobs:
- build:
context:
- org-global
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

are there other repos that now need this same change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for asking! I've gotten most of our other repos. I think there are a few PRs that I still need to clean up.