Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable postinstall script prior to publishing #925

Closed
wants to merge 1 commit into from
Closed

fix: disable postinstall script prior to publishing #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .husky/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
_
_
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the original PR I added a newline to this .gitignore because it's generally good practice for files to end with newlines. However, every time husky install runs (which happens after every yarn install, it updates this file. Might as well merge it in this PR so it won't show up as a random diff for anyone.

Copy link
Contributor Author

@brandonlenz brandonlenz Feb 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference since github doesn't really show this change very well on the Conversation tab:
image

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"lint": "tsc --noEmit && eslint --ext js,jsx,ts,tsx src && stylelint \"src/**/*.{css,scss}\"",
"release": "standard-version -t ''",
"prepare": "yarn build",
"prepublishOnly": "yarn test && yarn lint",
"prepublishOnly": "yarn test && yarn lint && pinst --disable",
"happo": "happo",
"happo-ci": "happo-ci-circleci",
"example:install": "yarn build && cd example/ && yarn",
Expand Down