-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New Component: Step indicator #952
Conversation
- Also to avoid confusion if there is another "Step" related component/subcomponent in the future
<span className="usa-step-indicator__current-step"> | ||
{currentStepNumber} | ||
</span> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you noticed this
being present here but not in the uswds source code, I can add some context:
In the uswds examples, there are spaces as shown in the image below:
The spaces after the circled step number and after the total number of steps come from implicit spacing added between html
inline
elements (so long as the html elements are separated by newlines)
Since rendered react html is minified, the implicit spacing is not rendered, so I had to explicitly add spaces here.
I may raise an issue with uswds
. While this is not a quirky bug with a single browser, they may want to know about an inconsistency in display of one of their components when code is minified vs non-minified, similar to uswds/uswds#3997.
Let's definitely make an issue. I like the idea of starting a pattern for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to approve this just would like to get your 👀 on the counters
type again
Summary
Adds new Step Indicator Component.
Related Issues or PRs
closes: #487
Notes
of
in "3 of 5", for example. There are several different ways I can think of to handle this:How To Test
Checkout
bl-step-indicator-487
and run storybook to inspect the component variations furtherScreenshots (optional)
Default
No Labels
Centered Labels
Counters
Small Counters