Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow_s3 on logs bucket and define log_prefix #123

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Conversation

esacteksab
Copy link
Contributor

  • chore: ignore terraform lock file
  • chore: pre-commit autoupdate
  • chore: sort variables and remove unused variables
  • fix: fixes logging bucket permissions #122
  • docs: terraform_docs

I noticed that default_allow = false was set, not allowing any logging from AWS sources, but in order to log from S3 we need allow_s3 = true to be set. In addition, we need the s3_logs_prefix as well. This fixes #122.

In addition, I set the trussworks/logs/aws module version to 16.3.0 which needs this merged first. This is also what's driving the 5.43.0 minimum AWS provider version as there are fixes released in that version that don't exist in versions prior. It's possible, we also wait for this PR and change the trussworks/s3-private-bucket/aws module version also.

I also sorted the variables.tf and removed unused variables.

Verified

This commit was signed with the committer’s verified signature.
esacteksab Barry Morrison

Verified

This commit was signed with the committer’s verified signature.
esacteksab Barry Morrison

Verified

This commit was signed with the committer’s verified signature.
esacteksab Barry Morrison

Verified

This commit was signed with the committer’s verified signature.
esacteksab Barry Morrison

Verified

This commit was signed with the committer’s verified signature.
esacteksab Barry Morrison

Verified

This commit was signed with the committer’s verified signature.
esacteksab Barry Morrison

Verified

This commit was signed with the committer’s verified signature.
esacteksab Barry Morrison
@esacteksab esacteksab merged commit dbfb96e into main Jan 15, 2025
2 checks passed
@esacteksab esacteksab deleted the barry-fix-122 branch January 15, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logging bucket permissions
2 participants