Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expire inactive accounts #58

Merged
merged 12 commits into from
Feb 8, 2021
Merged

Expire inactive accounts #58

merged 12 commits into from
Feb 8, 2021

Conversation

sheenamt
Copy link
Contributor

@sheenamt sheenamt commented Feb 4, 2021

Add env variable to expire inactive accounts

Code changes:

  • Add env variable (LAST_USED_AGE) to expire keys that have not been accessed in X days
  • Update classes to incorporate new variable or use a default
  • Update logic to include to variable in deciding to expire key
  • Update and add tests to incorporate new variable

@sheenamt sheenamt force-pushed the expire-inactive-accounts branch from 025bb1e to 5b8c05b Compare February 4, 2021 23:04
mdrummerboy09
mdrummerboy09 approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@mdrummerboy09 mdrummerboy09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sheenamt sheenamt merged commit c279831 into master Feb 8, 2021
@sheenamt sheenamt deleted the expire-inactive-accounts branch February 8, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrummerboy09 mdrummerboy09 mdrummerboy09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheenamt @mdrummerboy09