Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds postgres support #37

Merged
merged 1 commit into from
May 26, 2021
Merged

feat: Adds postgres support #37

merged 1 commit into from
May 26, 2021

Conversation

soluchok
Copy link
Contributor

@soluchok soluchok commented May 21, 2021

Postgres support was removed from Trillian. See google/trillian#2432.
In this PR I copied everything they have + fixed it according to the latest changes.
Also, PR includes builds for log-server and log-signer.

Signed-off-by: Andrii Soluk [email protected]

@cla-bot cla-bot bot added the cla-signed label May 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021

Codecov Report

Merging #37 (42c7034) into main (1f29038) will decrease coverage by 1.33%.
The diff coverage is 83.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   86.45%   85.11%   -1.34%     
==========================================
  Files           8       13       +5     
  Lines         893     1693     +800     
==========================================
+ Hits          772     1441     +669     
- Misses         77      147      +70     
- Partials       44      105      +61     
Impacted Files Coverage Δ
pkg/storage/postgres/provider.go 76.47% <76.47%> (ø)
pkg/storage/postgres/queue.go 77.27% <77.27%> (ø)
pkg/storage/postgres/log_storage.go 80.68% <80.68%> (ø)
pkg/storage/postgres/admin_storage.go 86.74% <86.74%> (ø)
pkg/storage/postgres/tree_storage.go 89.80% <89.80%> (ø)
cmd/vct/startcmd/start.go 84.33% <100.00%> (+0.24%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f29038...42c7034. Read the comment docs.

Copy link
Contributor

@bstasyszyn bstasyszyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At one point maybe we should consider adding PostGreSQL support to the google/trillian project. It will be difficult to get latest bug fixes/features with a copy.

Signed-off-by: Andrii Soluk <[email protected]>
@troyronda troyronda merged commit f77a3da into trustbloc:main May 26, 2021
@soluchok soluchok deleted the adds_postgres branch May 26, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants