-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rootstock
chain
#3205
Add rootstock
chain
#3205
Conversation
cc: @alepc253 |
Hey, please add your network using custom network feature on mobile. |
Hi @Milerius I created this pull request while doing integration with alpha-wallet which uses this wallet-core sdk. And I added rootstock as custom network but still we need this integration to support the rootstock coin type. So that wallet could use the correct derivation path here The purpose of this pull request is not only to list rootstock network but to support the coin type as there are many other wallets using this sdk. I request to reconsider this pull request as it will open doors for rootstock network integration with multiple wallets using this sdk. 🙏 |
It's seems that tests are missing in CoinAddressDerivationTests kotlin/swift can you please fix @ahsan-javaiid |
Added the tests. Thanks for pointing it out. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adds Support for rootstock chain.
How to test
Same way as other EVM chains
Types of changes
Checklist
If you're adding a new blockchain