-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Title: Update documentation for API endpoints and usage examples #11
Conversation
WalkthroughThe changes involve the renaming and restructuring of API endpoints and their associated schemas in the OpenAPI specification. The endpoint for retrieving similar chunks has been renamed from Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
src/libs/Instill/openapi.yaml (3)
Line range hint
1550-1583
: Approve changes and suggest updates to related documentation and client code.The renaming of the endpoint summary, operationId, and request body schema improves clarity and consistency. The changes from "Retrieve similar chunks" to "View similar chunks" and "SimilarityChunksSearch" to "ViewChunks" better reflect the action being performed.
To ensure a smooth transition:
- Update any related documentation that references the old naming conventions.
- Modify client code that may be using the previous operationId or request body schema.
- Consider adding a deprecation notice for the old naming if backward compatibility is required.
1583-1583
: Approve response schema change and suggest updates to client code and documentation.The update of the response schema reference from "SimilarityChunksSearchResponse" to "ViewChunksResponse" maintains consistency with the other changes made to this endpoint. This improves the overall coherence of the API.
To ensure a smooth transition:
- Update any client code that may be expecting the old response schema name.
- Revise API documentation to reflect the new response schema name.
- If backwards compatibility is a concern, consider implementing a temporary alias or mapping between the old and new schema names.
Line range hint
1550-3402
: Summary of changes and their impact on the APIThe modifications to the
/v1alpha/namespaces/{namespaceId}/catalogs/{catalogId}/chunks/retrieve
endpoint improve the clarity and consistency of the API specification. The key changes include:
- Renaming the endpoint summary from "Retrieve similar chunks" to "View similar chunks"
- Updating the operationId from "SimilarityChunksSearch" to "ViewChunks"
- Changing the request body schema reference from "SimilarityChunksSearchBody" to "ViewChunksBody"
- Updating the response schema reference from "SimilarityChunksSearchResponse" to "ViewChunksResponse"
These changes enhance the overall coherence of the API but may require updates to related documentation, client code, and any systems relying on the previous naming conventions.
To ensure a smooth transition and maintain API stability:
- Implement versioning for this API change if not already in place.
- Consider providing a deprecation period for the old endpoint if backwards compatibility is required.
- Update all related documentation, including API references, guides, and examples.
- Notify API consumers about these changes and provide migration guidelines.
- Review and update any internal systems or services that may be using the old endpoint naming.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (6)
src/libs/Instill/Generated/Instill.CatalogClient.ViewChunks.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.ICatalogClient.ViewChunks.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.ViewChunksBody.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.ViewChunksResponse.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.ViewChunksResponse2.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/JsonSerializerContextTypes.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
- src/libs/Instill/openapi.yaml (5 hunks)
Summary by CodeRabbit