-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Update OpenAPI Specification for Instill API to v0.42.0-beta #19
Conversation
WalkthroughThe changes involve an update to the OpenAPI specification for the Instill API, transitioning from version Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
src/libs/Instill/openapi.yaml (3)
Line range hint
1020-1048
: New subscription endpoints addedTwo new endpoints have been added for retrieving subscription details:
- GET /v1beta/user/subscription
- GET /v1beta/organizations/{organizationId}/subscription
These endpoints are well-structured and consistent with the existing API design. They both return appropriate response schemas and include proper authentication checks.
Suggestion for improvement:
Consider adding a description field to theOrganizationSubscription
andUserSubscription
schemas to provide more context about the subscription details.
Line range hint
217-258
: Improved PATCH user endpointThe PATCH /v1beta/users/{userId} endpoint has been updated to clarify the request body requirements. The changes include a more detailed description of the update process and the fields that can be modified.
Suggestion for improvement:
Consider adding an example request body to further clarify the expected input for this endpoint.
Line range hint
1-3700
: Overall API specification reviewThe changes to the OpenAPI specification are well-implemented and consistent with the existing structure. The new endpoints and schema updates enhance the API's functionality and clarity. However, there are a few suggestions for further improvement:
- Add example request and response bodies for new endpoints, especially for the subscription-related endpoints.
- Ensure all schemas and endpoints have consistent and detailed descriptions.
- Consider adding a
deprecated
field to mark any endpoints or schemas that may be phased out in future versions.- Review the use of required fields across all schemas to ensure they accurately reflect the API's expectations.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- src/libs/Instill/openapi.yaml (1 hunks)
🧰 Additional context used
🔇 Additional comments (4)
src/libs/Instill/openapi.yaml (4)
12-12
: Version update confirmedThe API version has been correctly updated from v0.41.0-beta to v0.42.0-beta. This change is consistent with the summary provided.
Line range hint
291-316
: Enhanced user memberships endpointThe GET /v1beta/users/{userId}/memberships endpoint has been updated to provide a more detailed response structure for user memberships. The changes improve the clarity and usefulness of the endpoint.
Line range hint
2037-2043
: Enhanced GetAuthenticatedUserResponse schemaThe GetAuthenticatedUserResponse schema has been updated to include more detailed user information. This change improves the API's ability to provide comprehensive user data.
Line range hint
2188-2203
: Improved ListUsersResponse schemaThe ListUsersResponse schema has been enhanced to provide pagination details. This improvement allows for better handling of large result sets and is consistent with best practices for API design.
Summary by CodeRabbit
New Features
Improvements