-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Add GET endpoints for object upload and download to Instill API #26
Conversation
WalkthroughThe changes introduce two new GET endpoints to the Instill API's OpenAPI specification, allowing clients to upload and download objects. The new endpoints, Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
src/libs/Instill/openapi.yaml (3)
1703-1757
: LGTM! Well-structured endpoint for object upload URL.The new GET endpoint for obtaining an object upload URL is well-designed and properly documented. It includes all necessary parameters and follows good API design practices.
Consider adding a brief description of the endpoint's purpose in the summary, e.g., "Get a pre-signed URL for object upload".
1758-1804
: LGTM! Well-designed endpoint for object download URL.The new GET endpoint for obtaining an object download URL is well-structured and properly documented. It provides flexibility by allowing either objectUid or objectName for identification.
Consider adding a brief description of the endpoint's purpose in the summary, e.g., "Get a pre-signed URL for object download".
3399-3439
: LGTM! Comprehensive Object schema definition.The new Object schema is well-defined and includes all necessary properties for effective object management. It covers metadata, lifecycle information, and uses appropriate data types for each field.
Consider adding a brief description for the Object schema itself, explaining its purpose and usage within the API.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (14)
src/libs/Instill/Generated/Instill.IInstillClient.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IObjectClient.GetObjectDownloadURL.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IObjectClient.GetObjectUploadURL.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.IObjectClient.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.InstillClient.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.GetObjectDownloadURLResponse.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.GetObjectDownloadURLResponse2.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.GetObjectUploadURLResponse.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.GetObjectUploadURLResponse2.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.Models.Object.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.ObjectClient.GetObjectDownloadURL.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.ObjectClient.GetObjectUploadURL.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/Instill.ObjectClient.g.cs
is excluded by!**/generated/**
src/libs/Instill/Generated/JsonSerializerContextTypes.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
- src/libs/Instill/openapi.yaml (3 hunks)
🧰 Additional context used
🔇 Additional comments (2)
src/libs/Instill/openapi.yaml (2)
3254-3283
: LGTM! Well-defined response schemas for object upload and download URLs.The new schemas for GetObjectUploadURLResponse and GetObjectDownloadURLResponse are well-structured and consistent. They provide all necessary information for the client, including the URL, expiration time, and object details.
The use of a separate Object schema promotes reusability and maintainability.
Line range hint
1703-3439
: Summary: Excellent addition of object upload and download functionality.The changes to the OpenAPI specification introduce well-designed endpoints and schemas for object upload and download URLs. These additions enhance the API's capabilities for object management while maintaining consistency with the existing design.
The new endpoints and schemas are thoroughly documented and follow best practices in API design. This update significantly improves the API's functionality for handling objects within namespaces.
Summary by CodeRabbit
These enhancements improve the overall functionality of the API, making it easier for users to manage object uploads and downloads.