Implementing basic menu support. #144
Closed
+1,725
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinterdev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This pull request adds support for menus on the Windows platform via win32 APIs.
What is the current behavior?
Currently, there is no support for native menus.
What is the expected behavior?
There should be support for native menus.
How was the solution implemented?
Due to WebView2's threading model, we can't simply execute TrackPopupMenu. Thus, we choose to create a "menu thread" on which all of our menu operations occur. We communicate with the C# via a
OnClickedcallback, and we expect C# to properlyInvokeon the relevantPhotinoWindow.Fixed issues
#43
Remarks
@philippjbauer @MikeYeager