feat(tap): added 'tap' function #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrajchert
requested changes
Oct 8, 2018
README.md
Outdated
| @@ -104,6 +104,31 @@ const rejectedTask = Task.resolve(new Error()); | |||
| const rejectedPromise = toPromise(rejectedTask); | |||
| ``` | |||
|
|
|||
| ### `tap` | |||
|
|
|||
| The `tap` _function_ can be found in other libreries. It just takes a `callback` _function_ and return a function that calls the `callback` and _returns_ the _argument_. It's useful when you need to perform some side effect. Suppose you need to log the _resolved value_ at certain point of a `Task` _method chaining_. Without the `tap` _function_ you would probably do something like: | |||
There was a problem hiding this comment.
libraries...
Too many functions... try to modify with: It takes a callback and returns a function that invokes the callback with the parameter and pass it trough
README.md
Outdated
| Task | ||
| .resolve(0) | ||
| // <Some code here...> | ||
| .map(tap(console.log)) |
There was a problem hiding this comment.
Are you sure this works? when using console.log as a point free function weird things can happen
|
Gonza, cuando quieras reviví este PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
tapfunction, that calls a function and returns its parameter.Related issues
tap#12