add check

tsachiherman · Jun 15, 2021 · 957958a · 957958a
1 parent 3dc1512
commit 957958a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/ledger/onlineacct.go b/ledger/onlineacct.go
@@ -84,6 +84,7 @@ func (h *onlineTopHeap) Push(x interface{}) {
 // Pop implements heap.Interface
 func (h *onlineTopHeap) Pop() interface{} {
 	res := h.accts[len(h.accts)-1]
+	h.accts[len(h.accts)-1] = nil
 	h.accts = h.accts[:len(h.accts)-1]
 	return res
 }
diff --git a/ledger/onlineacct_test.go b/ledger/onlineacct_test.go
@@ -126,12 +126,13 @@ func TestOnlineTopHeap_Pop(t *testing.T) {
 		},
 	}
 
-	acct0 := h.accts[0]
-	acct1 := h.accts[1]
+	originalAccounts := h.accts
 
 	h.Pop()
 
 	require.Equal(t, 2, h.Len())
-	require.Equal(t, acct0, h.accts[0])
-	require.Equal(t, acct1, h.accts[1])
+	require.Equal(t, 3, cap(h.accts))
+	require.Equal(t, originalAccounts[0], h.accts[0])
+	require.Equal(t, originalAccounts[1], h.accts[1])
+	require.Nil(t, originalAccounts[2])
 }
diff --git a/ledger/roundlru.go b/ledger/roundlru.go
@@ -121,7 +121,7 @@ func (hlc *heapLRUCache) inc() {
 	}
 }
 func (hlc *heapLRUCache) reIndex() {
-	if hlc.entries.heap == nil || len(hlc.entries.heap) == 0 {
+	if len(hlc.entries.heap) == 0 {
 		return
 	}
 	minprio := hlc.entries.heap[0].useIndex