fix: Capture the url type error #285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IDisposable
pushed a commit
to 1904labs/dom-to-image-more
that referenced
this pull request
May 21, 2019
When a URL pattern has a query string the file-extension isn't matched correctly IFF the URL has . in the query parameters. This fix is from original dom-to-image repo by: https://github.com/CG-man tsayen#285
|
I have merged this into 1904labs@96fceff and will release ASAP |
|
Released in https://github.com/1904labs/dom-to-image-more v2.8.0 |
marcandrews
added a commit
to marcandrews/dom-to-image
that referenced
this pull request
Jan 28, 2020
* toCanvas returns a promise that is fulfilled with a canvas object. * ignore image with invalid src * Prepare for new package name. Adds Chrome fix to copy over the font when cloning. Adds scaling up the image to reduce blur. * Force-passed some tests that no longer work Made scale an option so tests can pass (defaults to 1) Fixed errors looking at external style-sheet rules. For now, don't test Firefox, don't check rendered canvas ::before ::after content, don't expect access to external sheets. * Fix badge * Bump release to 2.7.1 * 2.7.2 * Moving repository to 1904labs organization 2.7.3 * Fix JSFiddle link in issue template * Removed and excluded node_modules * Upgrade all packages. Fix all audit fails * 2.7.4 Bump version * Updating travis for node 8 * Allow text rendering test to run a bit longer * Optionally send (existing) credentials for authentication of external URI (CORS) requests. Cherry picked from iqdoq-dfischer@2bae568 Resolves tsayen#255 * Release 2.7.5 Includes ability to pass authentication on for CORS * fix export of 0 size canvas elements #3 fix for 1904labs#3 * Add tests and prepare release * 2.7.6 * Fix bower version * Update dev dependencies and fix test * Release 2.7.7 Upgrades all devDependencies and fixes unit test. * Extend timeout for image rendering test. * FIX: File extension error when URL has query parameters When a URL pattern has a query string the file-extension isn't matched correctly IFF the URL has . in the query parameters. This fix is from original dom-to-image repo by: https://github.com/CG-man tsayen#285 * Prepare for 2.8.0 release * fix font mangling * restore dist * remove postbuild * fix getCssRules * 1904labs > tsayen * revert * revert * yarn.lock Co-authored-by: Andreas Girgensohn <[email protected]> Co-authored-by: ioslh <[email protected]> Co-authored-by: Marc Brooks <[email protected]> Co-authored-by: Aidas Klimas <[email protected]> Co-authored-by: Adrien Pyke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the url is like:
'https://www.xxx.com/chem/test/11ff1508-0af7-7b6a-2cd4-70220d09af23.svg?75d126a1-21ab-4021-c6c4-13625372c042'
that will return 'svg?75d126a1-21ab-4021-c6c4-13625372c042', not 'svg'