Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: Implement --every flag for live updates #346

Merged
merged 3 commits into from
Oct 23, 2018
Merged

Conversation

tsenart
Copy link
Owner

@tsenart tsenart commented Oct 23, 2018

This commit introduces the --every flag in the report command which
enables reports to be written out at specified interval. This allows
inspection of results as attacks are happening, instead of after they
finish.

Fixes #345

This commit introduces the `--every` flag in the report command which
enables reports to be written out at specified interval. This allows
inspection of results as attacks are happening, instead of after they
finish.

Fixes #345
@tsenart tsenart requested a review from xla as a code owner October 23, 2018 09:40
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :octocat: :shipit: 🍡

LGTM, the flag naming is not very telling as it stands, but have no good idea how to improve that.

@tsenart
Copy link
Owner Author

tsenart commented Oct 23, 2018

the flag naming is not very telling as it stands, but have no good idea how to improve that.

It should read like english: vegeta report --every 100ms

@tsenart tsenart merged commit c175690 into master Oct 23, 2018
@tsenart tsenart deleted the live-reporters branch October 23, 2018 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants