Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make git tag naming scheme compatible with go mod #358

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Make git tag naming scheme compatible with go mod #358

merged 1 commit into from
Nov 21, 2018

Conversation

tsenart
Copy link
Owner

@tsenart tsenart commented Nov 21, 2018

As reported in #357, only tags of the format vMAJOR.MINOR.PATCH are
supported by go mod. This change set documents how we'll create tags
in that format for library versions which will point to the same ref as
the lib/vMAJOR.MINOR.PATCH tags.

Fixes #357

@tsenart
Make git tag naming scheme compatible with go mod
8170d36 
As reported in #357, only tags of the format `vMAJOR.MINOR.PATCH` are
supported by `go mod`. This change set documents how we'll create tags
in that format for library versions which will point to the same ref as
the `lib/vMAJOR.MINOR.PATCH` tags.

Fixes #357
@tsenart tsenart requested a review from xla as a code owner November 21, 2018 16:34
@tsenart tsenart merged commit d8ea552 into master Nov 21, 2018
@tsenart tsenart deleted the go-mod-compatibility branch November 21, 2018 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xla xla Awaiting requested review from xla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tsenart