Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golint is not respected in ci #365

Merged
merged 2 commits into from
Dec 30, 2018
Merged

golint is not respected in ci #365

merged 2 commits into from
Dec 30, 2018

Conversation

cappyzawa
Copy link
Contributor

@cappyzawa cappyzawa commented Dec 28, 2018

Background

Checklist

  • Git commit messages conform to community standards.
  • Each Git commit represents meaningful milestones or atomic units of work.
  • Changed or added code is covered by appropriate tests.

Copy link
Owner

@tsenart tsenart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@tsenart tsenart merged commit 0cabfc9 into tsenart:master Dec 30, 2018
@cappyzawa cappyzawa deleted the fix/lint branch December 30, 2018 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants