Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cpus): correct default of CPUs usage #379

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

mstruebing
Copy link
Contributor

Background

In the Readme is stated that the number of CPUs used defaults to 8 which isn't correct, see:

vegeta/main.go

Line 24 in 0cabfc9

cpus := fs.Int("cpus", runtime.NumCPU(), "Number of CPUs to use")

BTW: is the commit message okay or how should I name it?

Checklist

  • Git commit messages conform to community standards.
  • Each Git commit represents meaningful milestones or atomic units of work.
  • Changed or added code is covered by appropriate tests.

@mstruebing mstruebing requested review from tsenart and xla as code owners March 5, 2019 11:59
@tsenart
Copy link
Owner

tsenart commented Mar 5, 2019

This is just the output of running the command in my machine.

@tsenart tsenart closed this Mar 5, 2019
@tsenart tsenart reopened this Mar 5, 2019
@mstruebing
Copy link
Contributor Author

But on another machine it would be a different number, so I've updated the readme correctly.

@mstruebing mstruebing closed this Mar 5, 2019
@mstruebing mstruebing reopened this Mar 5, 2019
@mstruebing
Copy link
Contributor Author

Can someone restart travis?

@tsenart tsenart merged commit 3605d84 into tsenart:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants