metrics: Add Throughput to Metrics #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a `Throughput` field to the `Metrics` struct which represents the rate of successful requests per second. It is calculated by dividing the number of successful requests by the time span in seconds starting from the beginning of the earliest request in the result set and ending in the time the very last response arrived.
golangcibot
reviewed
Jul 19, 2019
| @@ -20,8 +24,10 @@ func main() { | |||
| } | |||
| }(time.Now()) | |||
|
|
|||
| http.ListenAndServe(os.Args[1], http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | |||
| atomic.AddUint64(&count, 1) | |||
| http.ListenAndServe(flag.Arg(0), http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | |||
There was a problem hiding this comment.
Error return value of http.ListenAndServe is not checked (from errcheck)
|
@tsenart Superb tool! Upon reading the documentation, I couldn't find a way to plot the throughput captured as part of the report. Can the doc be updated with that or is there any link I can read it on ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
Throughputfield to theMetricsstruct whichrepresents the rate of successful requests per second. It is calculated
by dividing the number of successful requests by the time span in
seconds starting from the beginning of the earliest request in the
result set and ending in the time the very last response arrived.