Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attack: Add -max-workers flag #421

Merged
merged 3 commits into from
Jul 19, 2019
Merged

attack: Add -max-workers flag #421

merged 3 commits into from
Jul 19, 2019

Conversation

tsenart
Copy link
Owner

@tsenart tsenart commented Jul 19, 2019

This PR introduces the -max-workers flag and associated function
options. This allows controlling the concurrency level that vegeta uses,
but can sacrifice reaching the requested -rate, in case the specified
max number of workers is below the what is needed to sustain such rate.

tsenart added 2 commits July 19, 2019 14:12
This commit introduces the `-max-workers` flag and associated function
options. This allows controlling the concurrency level that vegeta uses,
but can sacrifice reaching the requested `-rate`, in case the specified
max number of workers is below the what is needed to sustain such rate.
@tsenart tsenart requested a review from xla as a code owner July 19, 2019 12:12
README.md Outdated Show resolved Hide resolved
@tsenart
Copy link
Owner Author

tsenart commented Jul 19, 2019

@keegancsmith, @mrnugget: PTAL

Copy link

@mrnugget mrnugget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

@keegancsmith keegancsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants