pacer: Introduce LinearPacer #425
Conversation
This commit introduces a LinearPacer which paces an attack by starting at a given request rate and increasing linearly with the given slope. This is a pre-requisite for implementing #418
|
PTAL @mrnugget, @keegancsmith |
| } | ||
|
|
||
| expectedHits := p.hits(elapsed) | ||
| if hits == 0 || hits < uint64(expectedHits) { |
There was a problem hiding this comment.
why do you need to compare hits to 0? I would expect expectedHits to always be > 0
There was a problem hiding this comment.
It'd be zero if elapsed == 0. That shouldn't happen at runtime in the vegeta attack command, only in tests, or when called as a library with that value.
|
@tsenart i was about to open a question issue for ramp-up and ramp-down but then i saw this. Readme.md is not up to date with Should i expect a doc soon |
|
@anas-qa: I haven't had the time to implementing #418, so there's no way to use this via the CLI yet. |
|
Thanks @tsenart This would be a huge +1 once it is Hope soon 👍 |
|
Sorry I didn't get around to this, life sort-of got in the way. The code looks great, this is exactly the sort of thing you need to do destructive load-testing :-) |
This commit introduces a LinearPacer which paces an attack by starting
at a given request rate and increasing linearly with the given slope.
This is a pre-requisite for implementing #418