Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for P90 in Metrics #452

Merged
merged 3 commits into from
Oct 29, 2019
Merged

Add support for P90 in Metrics #452

merged 3 commits into from
Oct 29, 2019

Conversation

fxkr
Copy link
Contributor

@fxkr fxkr commented Oct 15, 2019

Background

Closes #28

To align with other systems like Prometheus which provides only P90, and got no P95.

Example output:

% go run github.com/tsenart/vegeta report results.bin
Requests      [total, rate, throughput]    39709, 7940.90, 302.50
Duration      [total, attack, wait]        30.162362361s, 5.000565258s, 25.161797103s
Latencies     [mean, 50, 90, 95, 99, max]  625.208116ms, 60.995µs, 3.991791ms, 9.797688ms, 30.00028521s, 30.026509326s
Bytes In      [total, mean]                2709828, 68.24
Bytes Out     [total, mean]                0, 0.00
Success       [ratio]                      22.98%
Status Codes  [code:count]                 0:30585  200:9124  
Error Set:
.....
# go run github.com/tsenart/vegeta report -type=json -buckets '[0,5ms]' results.bin|jq
{
  "latencies": {
    "total": 24826389112876,
    "mean": 625208116,
    "50th": 60995,
    "90th": 3991791,
    "95th": 9797688,
    "99th": 30000285210,
    "max": 30026509326
  },
 ...
}

Checklist

  • Git commit messages conform to community standards.
  • Each Git commit represents meaningful milestones or atomic units of work.
  • Changed or added code is covered by appropriate tests.

@fxkr fxkr requested review from tsenart and xla as code owners October 15, 2019 05:28
tsenart
tsenart previously approved these changes Oct 27, 2019
Copy link
Owner

@tsenart tsenart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fxkr
Copy link
Contributor Author

fxkr commented Oct 28, 2019

Done.

Also fixed typo "an" -> "and" in the same line in README.

The 90th in README is made up as I don't have the original results.bin.

I don't really see why the benchmark needs the P90, but added as requested.

Also rebased to master.

@tsenart tsenart mentioned this pull request Oct 28, 2019
3 tasks
@tsenart tsenart merged commit 423f835 into tsenart:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output requests that are over a configurable threshold
2 participants