Add the max-connections option #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The connections option is misleading, as it let you think that no more than the given number of connections will be established during the attack, whereas it does only control the maximum amount of idle connection in the pool, but keep the maximum number of connection unlimited. The max-connection sets the maximum number of connections per target host, which is what most people certainly expect the connections option does.
tsenart
approved these changes
Feb 8, 2020
| @@ -41,6 +41,9 @@ const ( | |||
| // DefaultConnections is the default amount of max open idle connections per | |||
| // target host. | |||
| DefaultConnections = 10000 | |||
| // DefaultMaxConnections is the default amount of connections per target | |||
| // host. | |||
There was a problem hiding this comment.
Suggested change
| // host. | |
| // host. Zero means no limit. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connections option is misleading, as it let you think that no more
than the given number of connections will be established during the
attack, whereas it does only control the maximum amount of idle connection
in the pool, but keep the maximum number of connection unlimited.
The max-connection sets the maximum number of connections per target
host, which is what most people certainly expect the connections option
does.
Background
Checklist