Fix: remove ioutil package #634
Closed
+28
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsenart
approved these changes
Jul 19, 2023
| @@ -201,7 +201,7 @@ func attack(opts *attackOpts) (err error) { | |||
| res := atk.Attack(tr, opts.rate, opts.duration, opts.name) | |||
| enc := vegeta.NewEncoder(out) | |||
| sig := make(chan os.Signal, 1) | |||
| signal.Notify(sig, os.Interrupt) | |||
| signal.Notify(sig, os.Interrupt, syscall.SIGTERM) | |||
There was a problem hiding this comment.
This change seems unrelated. Accidental?
There was a problem hiding this comment.
I think SIGTERM is also commonly used, so I add it. Can we add it in this pr? If not, I will remove it.
AlexanderYastrebov
added a commit
to AlexanderYastrebov/vegeta
that referenced
this pull request
Aug 17, 2023
ioutil is deprecated, see https://go.dev/doc/go1.16#ioutil Follow up on tsenart#634 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
to AlexanderYastrebov/vegeta
that referenced
this pull request
Aug 17, 2023
ioutil is deprecated, see https://go.dev/doc/go1.16#ioutil Follow up on tsenart#634 Signed-off-by: Alexander Yastrebov <[email protected]>
3 tasks
tsenart
pushed a commit
that referenced
this pull request
Aug 18, 2023
ioutil is deprecated, see https://go.dev/doc/go1.16#ioutil Follow up on #634 Signed-off-by: Alexander Yastrebov <[email protected]> Signed-off-by: Tomás Senart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
ioutil package is not recommand to use, instead use io package and os package
Checklist