Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use RELEASE_STATUS instead of is_trial mutator #2

Closed
wants to merge 1 commit into from

Conversation

dagolden
Copy link

is_trial is likely to become read-only as a part of
rjbs/Dist-Zilla#438 which adds support for customizing
release status

is_trial is likely to become read-only as a part of
rjbs/Dist-Zilla#438 which adds support for customizing
release status
@tsibley
Copy link
Owner

tsibley commented Apr 1, 2015

@dagolden Thanks! Will this patch only work once the PR you mentioned is merged into dzil?

@tsibley
Copy link
Owner

tsibley commented Apr 1, 2015

(I ask because it appears that's the case.)

@tsibley
Copy link
Owner

tsibley commented Apr 1, 2015

It seems like update should be using the TRIAL env var instead.

@dagolden
Copy link
Author

dagolden commented Apr 1, 2015

Yeah, to be backwards compatible, it probably should. Apologies.

tsibley added a commit that referenced this pull request Apr 1, 2015
As David Golden pointed out in PR #2, is_trial is likely to become
read-only as a part of rjbs/Dist-Zilla#438 which adds support for
customizing release status.

Using TRIAL maintains maximum compatibility with current versions of
dzil as well as future versions.
@tsibley
Copy link
Owner

tsibley commented Apr 1, 2015

Fixed in 0.05, just released.

@tsibley tsibley closed this Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants