Rewrite Lockr using tsdx #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsironis
force-pushed
the
v0.9.0
branch
5 times, most recently
from
19469c7 to
2b0a08e
Compare
tsironis
force-pushed
the
v0.9.0
branch
7 times, most recently
from
3f9fc75 to
1da2745
Compare
Release v0.9.0-beta.0 version Expose all function in a default export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been few years since this library was updated and it's long over due. We also have some security vulnerabilities in our dependencies that need to be immediately addressed.
I rewritten the entire library using Typescript and tsdx.
The test cases remain exactly the same, expect that now we use Jest and few of the matchers were updated, not that many though.
The coverage is not 100% and could be improved.
Let's make sure that nothing is left behind for the time being and we can make changes responding the reviews made by anyone interested.