Typographyをtailwind.configに追加 #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komura-c
commented
Jan 14, 2025
komura-c
commented
- Typographyをtailwind.configに追加しました
- https://www.figma.com/design/JKCppXvTVKtFGRa6hNYXBz/Web%E3%83%87%E3%82%B6%E3%82%A4%E3%83%B3?node-id=447-1035&t=1XRW1yQKA8YQIFFR-0
- text-10, text-32-bold などで利用できます
kp047i
reviewed
Jan 15, 2025
tailwind.config.ts
Outdated
| "10": ["10px", { fontWeight: 400 }], | ||
| "12": ["12px", { fontWeight: 400 }], | ||
| "14": ["14px", { fontWeight: 400 }], | ||
| "14-bold": ["14px", { fontWeight: 700 }], |
There was a problem hiding this comment.
@komura-c
[Q]
font weightは別でクラス指定してあげれば良いのかなと思ったんですがどう思いますか？
https://tailwindcss.com/docs/font-weight
There was a problem hiding this comment.
@kp047i
それであれば、font weightはデフォルトでfont-normal, font-boldがあるので要らないですかね？
この組み合わせしか使われてないのであれば、text-xxxでどちらも指定できた方が便利かなと思い追加しました！
kpさん的にはどちらの方が使いやすいでしょうか？
There was a problem hiding this comment.
@komura-c
個人的にはシンプルにサイズだけで良いかなと思いました！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.