New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use-after-free issue when closing a connection #997

Merged

tsl0922 merged 1 commit into tsl0922:main from jzw-weride:main

Oct 11, 2022

Contributor

jzw-weride commented Oct 4, 2022

async_cb frees process right after calling uv_close, which is prohibited. The correct method is using close callback.

See more information here


          Fix use-after-free issue when closing a connection

1f09e91

jzw-weride mentioned this pull request

Segmentation fault when closing clients by random order @1.7.1 and main #994

Closed

Contributor Author

jzw-weride commented Oct 4, 2022

I'm not sure why win10 build failed. But it seems not related to my change, since I didn't touch anything other than 1 file.

tsl0922 merged commit 4ca49a1 into tsl0922:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet